[uClinux-dev] [PATCH] m68k: always set stack frame format for ColdFire on thread start

Geert Uytterhoeven geert at linux-m68k.org
Sun Sep 16 15:23:49 EDT 2012


On Wed, Sep 12, 2012 at 7:13 AM,  <gerg at snapgear.com> wrote:
> From: Greg Ungerer <gerg at uclinux.org>
>
> The stack frame "format" field needs to be explicitly set on thread creation
> on ColdFire. For a normal long word aligned user stack pointer the frame
> format is 0x4.
>
> We were doing this for non-MMU ColdFire, but not for the case with MMU enabled.
> So fix it so we always do it if targeting ColdFire.
>
> The old code happend to rely on the stack frame format being inhereted from
> the process calling exec. Furture changes means that may not always work,
> so we really do want to set it explicitly.
>
> Signed-off-by: Greg Ungerer <gerg at uclinux.org>

The classic-m68k changes look fine, so
Acked-by: Geert Uytterhoeven <geert at linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the uClinux-dev mailing list