[uClinux-dev] [PATCH v2 1/2] mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver

Artem Bityutskiy dedekind1 at gmail.com
Fri Aug 17 09:16:40 EDT 2012


On Thu, 2012-07-19 at 15:42 +1000, gerg at snapgear.com wrote:
> From: Greg Ungerer <gerg at uclinux.org>
> 
> The uclinux.c mapping driver uses ioremap_nocache() to map its physical
> mapping address to a system virtual address. Problem is that the region
> it is mapping is not device memory. It is ordinary system RAM. On most
> non-MMU systems this doesn't matter, and the mapping is always a 1:1
> translation of the address. On paged memory systems on some architectures
> the page table mappings are not compatible between normal RAM and device
> memory.

I cannot compile m68k because of the following errors:

arch/m68k/platform/coldfire/clk.c:54:13: error: redefinition of 'clk_get'
include/linux/clk.h:281:27: note: previous definition of 'clk_get' was here
arch/m68k/platform/coldfire/clk.c:68:5: error: redefinition of 'clk_enable'
include/linux/clk.h:295:19: note: previous definition of 'clk_enable' was here
arch/m68k/platform/coldfire/clk.c:80:6: error: redefinition of 'clk_disable'
include/linux/clk.h:300:20: note: previous definition of 'clk_disable' was here
arch/m68k/platform/coldfire/clk.c:90:6: error: redefinition of 'clk_put'
include/linux/clk.h:291:20: note: previous definition of 'clk_put' was here
arch/m68k/platform/coldfire/clk.c:97:15: error: redefinition of 'clk_get_rate'
include/linux/clk.h:302:29: note: previous definition of 'clk_get_rate' was here
arch/m68k/platform/coldfire/clk.c:150:13: error: redefinition of 'devm_clk_get'
include/linux/clk.h:286:27: note: previous definition of 'devm_clk_get' was here
make[2]: *** [arch/m68k/platform/coldfire/clk.o] Error 1

so I cannot compile-test this patch. Do you have a work-around patch for
that compilation issue?

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.uclinux.org/pipermail/uclinux-dev/attachments/20120817/ad2ec4dc/attachment.sig>


More information about the uClinux-dev mailing list