[uClinux-dev] Re: [PATCH 1/2] m68knommu: create config options for CPU classes

Greg Ungerer gerg at snapgear.com
Thu Jun 9 23:56:13 EDT 2011


Hi Geert,

Are you happy enough with these patches the way they are?

The 3 files they directly touch (arch/m68k/lib/memset.c,
memcpy.c and muldi3.c) are not changes based on presence of
bitfield instructions. They should resolve the problem of
building with older compilers.

I have these 2 and the vmlinux.lds_no.S fix to send to
Linus real soon, for 3.0.0.

Regards
Greg



On 03/06/11 21:15, Geert Uytterhoeven wrote:
> On Fri, Jun 3, 2011 at 08:43,<gerg at snapgear.com>  wrote:
>> From: Greg Ungerer<gerg at uclinux.org>
>>
>> There are 3 families of CPU core types that we support in the m68knommu
>> architecture branch. They are
>>
>> . traditional 68000
>> . CPU32 (which is a 68020 core derivitive without MMU)
>
> derivative ... and without bitfield instructions.
>
>> . ColdFire
>
>> It will be useful going forward to have a CONFIG_ option defined for
>> each type. We already have one for ColdFire (CONFIG_COLDFIRE), so add
>> for the other 2 families, CONFIG_M68000 and CONFIG_MCPU32.
>
> I'm wondering whether it would help to have Kconfig symbols for the
> instruction capabilities as well.
> Then you have to document these capabilities in the kconfig definition only,
> and can use single (e.g.) #ifdef CONFIG_CPU_HAS_BITFIELDS tests everywhere
> else, instead of duplicating the logic at every #ifdef.
>
>> Signed-off-by: Greg Ungerer<gerg at uclinux.org>
>> ---

------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com



More information about the uClinux-dev mailing list