[uClinux-dev] Re: [PATCH] FLAT: fix unmap len in load error path

Greg Ungerer gerg at snapgear.com
Fri May 28 02:47:57 EDT 2010


Mike Frysinger wrote:
> The data chunk is mmaped with 'len' which remains unchanged, so use that
> when unmapping in the error path rather than trying to recalculate (and
> incorrectly so) the value used originally.
> 
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>

Acked-by: Greg Ungerer <gerg at uclinux.org>


> ---
>  fs/binfmt_flat.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
> index 4959a0a..f7a4059 100644
> --- a/fs/binfmt_flat.c
> +++ b/fs/binfmt_flat.c
> @@ -596,7 +596,7 @@ static int load_flat_file(struct linux_binprm * bprm,
>  		if (IS_ERR_VALUE(result)) {
>  			printk("Unable to read data+bss, errno %d\n", (int)-result);
>  			do_munmap(current->mm, textpos, text_len);
> -			do_munmap(current->mm, realdatastart, data_len + extra);
> +			do_munmap(current->mm, realdatastart, len);
>  			ret = result;
>  			goto err;
>  		}


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com



More information about the uClinux-dev mailing list