[uClinux-dev] [PATCH] : Avoid filename < TASK_SIZE test =?iso-8859-1?q?in=09do=5Fgetname?=() when no MMU

Mike Frysinger vapier at gentoo.org
Sun May 23 21:52:52 EDT 2010


On Sunday 23 May 2010 21:29:50 Greg Ungerer wrote:
> David Howells wrote:
> > Geert Uytterhoeven <geert at linux-m68k.org> wrote:
> >> Are these also problematic?
> > 
> > None of these are problematic for NOMMU FRV because there I set:
> > 	#define TASK_SIZE			__UL(0xFFFFFFFFUL)
> > 
> > I would set it lower, but the flash is right at the top end of the
> > address space, and if I want to do XIP from it, this is required.  It's
> > a fairly meaningless constant in NOMMU anyway, so it's probably better
> > just to set it to this.  Actually, I should probably use ULONG_MAX
> > instead.
> 
> This seems like a better option that all the use cases.
> 
> So something like:
> 
> --
> [PATCH] m68knommu: remove size limit on non-MMU TASK_SIZE
> 
> The TASK_SIZE define is used in some places as a limit on the size
> of the virtual address space of a process. On non-MMU systems those
> addresses used in comparison will be physical addresses, and they
> could be anywhere in the 32bit physical address space. So for
> !CONFIG_MMU systems set the TASK_SIZE to the maximum physical
> address.

fwiw, we do (and always have afaict) the same thing for Blackfin systems
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.uclinux.org/pipermail/uclinux-dev/attachments/20100523/1a53935d/attachment.sig>


More information about the uClinux-dev mailing list