[uClinux-dev] [PATCH] : Avoid filename < TASK_SIZE test in do_getname() when no MMU

Greg Ungerer gerg at snapgear.com
Mon May 24 21:19:43 EDT 2010


Hi Philippe,

Philippe De Muyter wrote:
> On Mon, May 24, 2010 at 11:29:50AM +1000, Greg Ungerer wrote:
> [...]
>> +#else
>> +#define TASK_SIZE	(0xFFFFFFFFUL)
>> +#endif
> 
> Because of do_getname() :
> 
> 	len = TASK_SIZE - (unsigned long) filename;
> 
> we should rather have
> 
> 	#define TASK_SIZE (0x100000000ull)

I see what you mean. But in practice here I don't think it matters.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com



More information about the uClinux-dev mailing list