[uClinux-dev] nios2: asm/scatterlist.h definitely needs some updating

[Thomas Chou]

Yes, it should be updated as the latest kernel changes. I will run some 
disk IO to verify it.
I did BORROW them mostly from SH or MIPS.

Thomas

Robert P. J. Day wrote:
>   i'm about to go off and drink beer, but here's the most recent
> (albeit minor) obstacle -- the asm/scatterlist.h file for NIOS2 needs
> some updating.  here's the current version (clearly stolen outright
> from the SH version, so i'll fix that):
>
> =================================
> #ifndef __ASM_SH_SCATTERLIST_H
> #define __ASM_SH_SCATTERLIST_H
>
> struct scatterlist {
>     struct page * page; /* Location for highmem page, if any */
>     unsigned int offset;/* for highmem, page offset */
>     dma_addr_t dma_address;
>     unsigned int length;
> };
>
> #define ISA_DMA_THRESHOLD (0xffffffff)
>
> #endif /* !(__ASM_SH_SCATTERLIST_H) */
> =================================
>
>   in the meantime, all the other architectures look much more like
> this:
>
> =================================
> #ifndef __ASM_SH_SCATTERLIST_H
> #define __ASM_SH_SCATTERLIST_H
>
> #include <asm/types.h>
>
> struct scatterlist {
> #ifdef CONFIG_DEBUG_SG
>     unsigned long sg_magic;
> #endif
>     unsigned long page_link;
>     unsigned int offset;/* for highmem, page offset */
>     dma_addr_t dma_address;
>     unsigned int length;
> };
>
> #define ISA_DMA_THRESHOLD (0x1fffffff)
>
> /* These macros should be used after a pci_map_sg call has been done
>  * to get bus addresses of each of the SG entries and their lengths.
>  * You should only work with the number of sg entries pci_map_sg
>  * returns, or alternatively stop on the first sg_dma_len(sg) which
>  * is 0.
>  */
> #define sg_dma_address(sg)      ((sg)->dma_address)
> #define sg_dma_len(sg)          ((sg)->length)
>
> #endif /* !(__ASM_SH_SCATTERLIST_H) */
>
> ==================================
>
>   note particularly the new "unsigned long page_link" member, which is
> absolutely necessary.  if anyone is feeling ambitious, feel free to
> supply an appropriate nios2-specific scatterlist.h header file, or
> i'll just fake it and make it look vaguely like the rest and take my
> chances.
>
> rday
>
>