[uClinux-dev] nios2 error: thread_info is now stack

[Robert P. J. Day]

  yet another build error for NIOS II (which may very well affect
other architectures):

...
  CC      arch/nios2nommu/kernel/asm-offsets.s
arch/nios2nommu/kernel/asm-offsets.c: In function `main':
arch/nios2nommu/kernel/asm-offsets.c:34: error: structure has no member named `thread_info'
make[2]: *** [arch/nios2nommu/kernel/asm-offsets.s] Error 1
make[1]: *** [prepare0] Error 2
make[1]: Leaving directory `/home/rpjday/nios2/uclinux/uClinux-dist-cvs/linux-2.6.x'
make: *** [linux] Error 1
$

  yes, that's a problem since "thread_info" has been renamed to
"stack", as per this:

http://lkml.org/lkml/2007/4/30/551

which will clearly cause problems in that asm-offsets.c file:

int main(void)
{

        /* offsets into the task struct */
        DEFINE(TASK_STATE, offsetof(struct task_struct, state));
        DEFINE(TASK_FLAGS, offsetof(struct task_struct, flags));
        DEFINE(TASK_PTRACE, offsetof(struct task_struct, ptrace));
        DEFINE(TASK_BLOCKED, offsetof(struct task_struct, blocked));
        DEFINE(TASK_THREAD, offsetof(struct task_struct, thread));
        DEFINE(TASK_THREAD_INFO, offsetof(struct task_struct, thread_info));  ... uh oh ...

so the obvious question is, what *should* that DEFINE look like?  is
it actually wanting to refer to thread_info itself?  or to the stack?

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================