[uClinux-dev] [PATCH] fec cleanup : else + icr

[Greg Ungerer]

Hi Philippe,

Philippe De Muyter wrote:
>>> -	for(k = 0; (c+k)->mii_data != mk_mii_end; k++) {
>>> -		mii_queue(dev, (c+k)->mii_data, (c+k)->funct);
>>> -	}
>> This looks odd, why is this change needed?
>>
>>> +	for ( ; c->mii_data != mk_mii_end; c++)
>>> +		mii_queue(dev, c->mii_data, c->funct);
>>> }
> 
> I find the second version more readable, that's all, but if you don't like it,
> no problem.

Oh, no, it is much more readable. I didn't realize that this
change was that comment at the top.

Thanks
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg at snapgear.com
SnapGear -- a Secure Computing Company      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com