[uClinux-dev] [PATCH] fec cleanup : else + icr

[Philippe De Muyter]

On Tue, Mar 27, 2007 at 10:35:32AM +1000, Greg Ungerer wrote:
> Hi Philippe,
> 
> Philippe De Muyter wrote:
[...]
> >- Improve the readability of mii_do_cmd.
[...]
> >@@ -770,14 +768,11 @@ mii_queue(struct net_device *dev, int re
> > 
> > static void mii_do_cmd(struct net_device *dev, const phy_cmd_t *c)
> > {
> >-	int k;
> >-
> > 	if(!c)
> > 		return;
> > 
> >-	for(k = 0; (c+k)->mii_data != mk_mii_end; k++) {
> >-		mii_queue(dev, (c+k)->mii_data, (c+k)->funct);
> >-	}
> 
> This looks odd, why is this change needed?
> 
> Regards
> Greg
> 
> 
> 
> >+	for ( ; c->mii_data != mk_mii_end; c++)
> >+		mii_queue(dev, c->mii_data, c->funct);
> > }

I find the second version more readable, that's all, but if you don't like it,
no problem.

Regards

Philippe