[uClinux-dev] [RFC] MicroBlaze 2.6.19-uc0 patches

[Greg Ungerer]

Hi John,

John Williams wrote:
> Patches to add MicroBlaze arch support and preliminary drivers for 
> several Xilinx devices to linux-2.6.19-uc0 can be found here:
> 
> http://developer.petalogix.com/wiki/MicroBlaze-2.6-Kernel#Otherpatches
> 
> The patch set is roughly 800kb so too large to post here as an attachment.
> 
> It's broadly based on the 2.6.14.3 patch set dropped anonymously at 
> www.sourceforge.com/microblaze in January of this year and mentioned on 
> this list at around the same time.
> 
> The patch as it stands is not intended for inclusion / push to LKML, but 
> rather just put out there for discussion.  All comments and advice welcomed

Just a few random thoughts to get started:

1. you need to break up the big patch into more manageable peices.
    I would suggest that each driver become its own patch, asm-microblaze
    another, and arch/microblaze another. At least that is a good
    starting point.

2. any place you have comments like "FIXME" you need to clean up now
    (for example include/asm-microblaze/bitops.h)

3. clean up any places you have debug changes
    (for example net/Kconfig)

4. for review on lkml make sure that you are diffing against a stock
    Linus kernel (not a -uc kernel)

5. definately clean up the usr/ changes.

6. include/asm-microblaze/unistd.h should no longer have the syscall
    macros.

7. implement any important missing peices (like the show_cpuinfo()
    function in arch/microblaze/kernel/setup.c, show_interrupts()
    in arch/microblaze/kernelirq.c)

8. what is all the bluecat_ stuff in arch/microblaze/kernel/setup.c
    and quite a few other places?

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg at snapgear.com
Secure Computing Corporation                PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com